Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(intersection): handle pass judge after red/arrow-signal to ignore NPCs after the signal changed to green again #1602

Merged
merged 18 commits into from
Oct 31, 2024
Merged

fix(intersection): handle pass judge after red/arrow-signal to ignore NPCs after the signal changed to green again #1602

merged 18 commits into from
Oct 31, 2024

Conversation

soblin
Copy link

@soblin soblin commented Oct 23, 2024 •
edited
Loading

Description

#1601 に依存

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

soblin and others added 18 commits October 23, 2024 20:21
@soblin
feat(intersection): disable stuck detection against private lane (aut…
2d86e2f 
…owarefoundation#5910)

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
fix(intersection): fix private condition (autowarefoundation#5975)
01e360e
@soblin
refactor(intersection): cleanup utility function (autowarefoundation#…
f974193 
…5972)

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
feat(intersection): distinguish 1st/2nd attention lanelet (autowarefo…
2cba3d4 
…undation#6042)
@soblin
fix(intersection): fix bugs (autowarefoundation#6050)
3c03357 
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
feat(intersection): more precise pass judge handling considering occl…
257c4a4 
…usion detection and 1st/2nd attention lane (autowarefoundation#6047)

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
feat(behavior_velocity): add the option to keep the last valid observ…
6cea81f 
…ation (autowarefoundation#6036)

* feat(behavior_velocity): add the option to keep the last valid observation

Signed-off-by: Mamoru Sobue <[email protected]>

* keep_last_observation is false by default and intersection/traffic_light is explicily true

Signed-off-by: Mamoru Sobue <[email protected]>

* for intersection

Signed-off-by: Mamoru Sobue <[email protected]>

---------

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
refactor(intersection): divide source files and modifyPathVelocity (a…
c3b1cd3 
…utowarefoundation#6134)

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
feat(intersection): publish and visualize the reason for dangerous si…
80d3ca4 
…tuation to blame past detection fault retrospectively (autowarefoundation#6143)

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
fix(intersection): judge pass judge at intersection without tl with o…
b438fbe 
…cclusion detection (autowarefoundation#6207)

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
feat(intersection_occlusion)!: react RTC disapproval and stop even if…
67bb644 
… occlusion detection is OFF (autowarefoundation#6279)

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
fix(merge_from_private): fix stop position calculation (autowarefound…
a2c71a8 
…ation#6286)

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
fix(intersection): fix stopline midpoint calculation (autowarefoundat…
71a9541 
…ion#6315)

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
chore(intersection): add const to member functions, replace enum with…
88d4132 
… class tag for occlusion (autowarefoundation#6299)

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
fix(intersection): fix possible invalid access (autowarefoundation#6542)
dbb2b2f 
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
feat(intersection): resurrect debug ego-object ttc visualizer (autowa…
3f24def 
…refoundation#6829)

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
minimize diff
3eb2992 
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin
PR9119
8fc3897 
Signed-off-by: Mamoru Sobue <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed

Issues
62 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarCloud

@soblin soblin marked this pull request as ready for review October 23, 2024 12:33
@soblin soblin merged commit 302674a into beta/v0.19.1-pc-develop Oct 31, 2024
14 of 18 checks passed
@soblin soblin deleted the feat/intersection-RT33896-2 branch October 31, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem maxime-clem is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

Assignees
No one assigned
Labels
component:planning type:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soblin @takayuki5168